Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@uppy/core: fix uppy.resetProgress() #4337

Merged
merged 2 commits into from
Mar 2, 2023
Merged

@uppy/core: fix uppy.resetProgress() #4337

merged 2 commits into from
Mar 2, 2023

Conversation

arturi
Copy link
Contributor

@arturi arturi commented Feb 28, 2023

Fixes this issue with Status Bar and by allowing new upload after progress is reset:

Screen.Recording.2023-02-28.at.18.07.08.mov

@arturi
Copy link
Contributor Author

arturi commented Feb 28, 2023

I could also add the multipart progress reset fix here, if @aduh95 approves, but if it requires a bit more time, then we'll need to postpone.

Copy link
Member

@Murderlon Murderlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could benefit from a unit test perhaps.

@Murderlon Murderlon changed the title core: fix uppy.resetProgress() @uppy/core: fix uppy.resetProgress() Mar 1, 2023
@arturi
Copy link
Contributor Author

arturi commented Mar 2, 2023

Updated the test!

@arturi arturi merged commit 222e511 into main Mar 2, 2023
@arturi arturi deleted the fix-reset-progress branch March 2, 2023 20:16
@github-actions github-actions bot mentioned this pull request Mar 7, 2023
github-actions bot added a commit that referenced this pull request Mar 7, 2023
| Package              | Version | Package              | Version |
| -------------------- | ------- | -------------------- | ------- |
| @uppy/audio          |   1.1.0 | @uppy/onedrive       |   3.1.0 |
| @uppy/box            |   2.1.0 | @uppy/provider-views |   3.1.0 |
| @uppy/core           |   3.1.0 | @uppy/screen-capture |   3.1.0 |
| @uppy/dashboard      |   3.3.0 | @uppy/unsplash       |   3.1.0 |
| @uppy/dropbox        |   3.1.0 | @uppy/url            |   3.2.0 |
| @uppy/facebook       |   3.1.0 | @uppy/utils          |   5.1.3 |
| @uppy/google-drive   |   3.1.0 | @uppy/webcam         |   3.3.0 |
| @uppy/image-editor   |   2.1.1 | @uppy/zoom           |   2.1.0 |
| @uppy/instagram      |   3.1.0 | uppy                 |   3.6.0 |
| @uppy/locales        |   3.0.7 |                      |         |

- @uppy/locales: add missing entries after build (Murderlon)
- @uppy/dashboard: update provider icon style (Alexander Zaytsev / #4345)
- @uppy/core: fix uppy.resetProgress() (Artur Paikin / #4337)
- @uppy/core: fix some types (Antoine du Hamel / #4332)
- @uppy/core: Fixed type of State.info to match reality being an array of info objects (Marc Bennewitz / #4321)
- @uppy/image-editor: Fix TypeScript error in image-editor types (Matthias Kunnen / #4334)
- meta: improve `importFromUploadURLs` docs (Mikael Finstad / #4323)
- @uppy/utils: workaround chrome crash (Mikael Finstad / #4310)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants